[QC-310] Refresh config in Runners::init#1010
Merged
Merged
Conversation
Add config refresh but do not use it.
knopers8
requested changes
Jan 17, 2022
Collaborator
knopers8
left a comment
knopers8
left a comment
There was a problem hiding this comment.
Thanks, indeed let's keep Check Runners for another PR, that is already significant. Please see my comments.
Co-authored-by: Piotr Konopka <piotr.jan.konopka@cern.ch>
Co-authored-by: Piotr Konopka <piotr.jan.konopka@cern.ch>
knopers8
approved these changes
Jan 21, 2022
Collaborator
|
Please resolve the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the ptree provided by ECS via DPL/FairMQ to rebuild a config in
init()and use it. If it is not available we just keep the one we got at the beginning.I had to refactor a bit to have something understandable in the runners and be able to reconfigure.
One thing is missing in the PR: the CheckRunner does not actually apply the config. This will be done in a later PR as it will require some refactoring and this PR is already too big.